Skip to content

refactor: eslint setup#493

Merged
erisu merged 1 commit into
apache:masterfrom
erisu:v10-eslint
Nov 19, 2019
Merged

refactor: eslint setup#493
erisu merged 1 commit into
apache:masterfrom
erisu:v10-eslint

Conversation

@erisu

@erisu erisu commented Nov 18, 2019

Copy link
Copy Markdown
Member

Description

  • replace eslint dependencies with @cordova/eslint-config
  • update eslint config
  • eslint corrections
  • combine testing and core configs

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 10.0.0 milestone Nov 18, 2019
@erisu erisu requested a review from raphinesse November 18, 2019 08:33
Comment thread package.json Outdated
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #493 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files           3        3           
  Lines         255      255           
=======================================
  Hits          221      221           
  Misses         34       34
Impacted Files Coverage Δ
src/telemetry.js 100% <ø> (ø) ⬆️
src/cli.js 83.96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ce340...5e84f0a. Read the comment docs.

* replace eslint dependencies with @cordova/eslint-config
* update eslint config
* eslint corrections
* combine testing and core configs
@erisu erisu merged commit 63fd6f9 into apache:master Nov 19, 2019
@erisu erisu deleted the v10-eslint branch November 19, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants