Skip to content

Conversation

@eye-gu
Copy link
Contributor

@eye-gu eye-gu commented Feb 17, 2025

What is the purpose of the change?

close #14499

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.71%. Comparing base (dddeb25) to head (f688cfc).
⚠️ Report is 223 commits behind head on 3.3.

Files with missing lines Patch % Lines
.../dubbo/rpc/aot/GenericProxyDescriberRegistrar.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15139      +/-   ##
============================================
- Coverage     60.71%   60.71%   -0.01%     
- Complexity    10879    10883       +4     
============================================
  Files          1884     1885       +1     
  Lines         86050    86058       +8     
  Branches      12893    12893              
============================================
+ Hits          52249    52250       +1     
- Misses        28347    28356       +9     
+ Partials       5454     5452       -2     
Flag Coverage Δ
integration-tests 33.08% <0.00%> (+<0.01%) ⬆️
samples-tests 29.20% <0.00%> (+0.01%) ⬆️
unit-tests 58.82% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eye-gu eye-gu requested a review from AlbumenJ February 21, 2025 02:53
@AlbumenJ
Copy link
Member

@CrazyHZM PTAL

@CrazyHZM CrazyHZM merged commit a5604cd into apache:3.3 Feb 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Compile native, not support generic invoke

5 participants