-
Notifications
You must be signed in to change notification settings - Fork 26.6k
fixed the issue that the file name of message.proto is not supported #15655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15655 +/- ##
============================================
+ Coverage 61.02% 61.03% +0.01%
- Complexity 11703 11706 +3
============================================
Files 1923 1923
Lines 87078 87078
Branches 13113 13113
============================================
+ Hits 53139 53148 +9
+ Misses 28499 28487 -12
- Partials 5440 5443 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It seems there might be an issue with the action, but I can't see the specific reason. |
I don't understand why my changes would affect this part, I tested |
it's not your fault, it seemed that dubbo-samples-metrics-prometheus need to be fixed as its consumer doesn't generate metrics data as soon as possible. |
|
you'd better add a unit test case to ensure this PR has fixed the issue #15410 |
got it |
|
LGTM |
EarthChen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@oxsean do not merge until next release? |

What is the purpose of the change?
Checklist