Skip to content

Conversation

@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Sep 2, 2025

What is the purpose of the change?

Fix cert expired when reconnect

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@oxsean oxsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@icodening icodening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.44%. Comparing base (87d6786) to head (7c5a080).
⚠️ Report is 3 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.2   #15664   +/-   ##
=========================================
  Coverage     41.44%   41.44%           
+ Complexity    10539    10536    -3     
=========================================
  Files          1652     1652           
  Lines         71461    71461           
  Branches      10163    10163           
=========================================
+ Hits          29619    29620    +1     
+ Misses        37716    37712    -4     
- Partials       4126     4129    +3     
Flag Coverage Δ
integration-tests 38.44% <100.00%> (+<0.01%) ⬆️
samples-tests 36.48% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EarthChen EarthChen merged commit 717053e into apache:3.2 Sep 5, 2025
32 of 38 checks passed
qijun4tian pushed a commit to qijun4tian/dubbo that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants