-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19564: delete configuration io.compression.codec.lzo.buffersize in core-default.xml #7708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not make sense to me.
The default value is 245 MB.
Conclusions should be supported by evidence.
The default value should be controlled by ZLO and should not be contained in the core-site file.
It is common for downstream projects to provide different default values for certain configuration items when using a library. If you think the current default value should be changed, please provide benchmarks to support your idea.
The lzo's code is in a separate repository. I don't think we should maintain default values related to lzo. It should be in hadoop-lzo repository not in hadoop. |
Description of PR
PR for HADOOP-19564
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?