[594] Support continuous conversion with the RunSync tool #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-other-tim-brown
changed the title
the-other-tim-brown
changed the title
the-other-tim-brown
force-pushed
the
continuous-mode
branch
from
82c0d59 to
e3d541b
Compare
the-other-tim-brown
force-pushed
the
continuous-mode
branch
from
afd51ec to
98a8ea3
Compare
| 0, | ||
| intervalInSeconds, | ||
| TimeUnit.SECONDS); | ||
| while (!Thread.interrupted()) { |
There was a problem hiding this comment.
This method clears the interrupted status for the thread, do we need that here ?
Thread.currentThread().isInterrupted(false) doesn't clear the interrupted state after the check.
There was a problem hiding this comment.
nice catch, I need to check the current thread which has an instance method which does not clear the state
vinishjail97
approved these changes
Mar 10, 2025
the-other-tim-brown
force-pushed
the
continuous-mode
branch
from
c68ee52 to
0104385
Compare
|
Can you squash into one commit before merging ? Thanks ! |
This was referenced Mar 14, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Addresses #594, Adds a continuous mode for running
RunSyncat a scheduled intervalBrief change log
Verify this pull request