[668] Support bucket partition transform for Iceberg Sources and Delta Targets #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
| @@ -47,4 +49,6 @@ public class InternalPartitionField { | |||
| @Builder.Default List<String> partitionFieldNames = Collections.emptyList(); | |||
| // An enum describing how the source data was transformed into the partition value | |||
| PartitionTransformType transformType; | |||
| // Transform options such as number of buckets in the BUCKET transform type | |||
| @Builder.Default Map<String, Object> transformOptions = Collections.emptyMap(); | |||
There was a problem hiding this comment.
Instead of Object, should we add a new class known as InternalValue ?
InternalValue {
InternalType type;
Object value;
}
There was a problem hiding this comment.
Right now, I made this similar to the metadata in InternalSchema. Another option I considered is to change PartitionTransformType into a class which can then have its own instance variables.
There was a problem hiding this comment.
This approach is okay for now.
vinishjail97
approved these changes
Apr 1, 2025
the-other-tim-brown
force-pushed
the
668-bucket-partition-transform
branch
from
f6077b0 to
ea1b532
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Addresses #668
Adds support for handling Iceberg's Bucket partitioning when converting to Delta Lake.
Brief change log
Verify this pull request