Skip to content

[678] Add contribution guidelines to reflect stale PR's guidelines #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ docker run \
For setting up the repo on IntelliJ, open the project and change the Java version to Java 11 in File->ProjectStructure
![img.png](style/IDE.png)

You have found a bug, or have a cool idea you that want to contribute to the project ? Please file a GitHub issue [here](https://github.com/apache/incubator-xtable/issues)
Found a bug or have a cool idea to contribute? Open a GitHub [issue](https://github.com/apache/incubator-xtable/issues) to get started. For more contribution guidelines and ways to stay involved, visit our [community](https://xtable.apache.org/community/sync) page.

## Adding a new target format
Adding a new target format requires a developer implement [ConversionTarget](./xtable-api/src/main/java/org/apache/xtable/spi/sync/ConversionTarget.java). Once you have implemented that interface, you can integrate it into the [ConversionController](./xtable-core/src/main/java/org/apache/xtable/conversion/ConversionController.java). If you think others may find that target useful, please raise a Pull Request to add it to the project.
Expand Down
22 changes: 22 additions & 0 deletions website/community/sync.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,28 @@ Here's a quick view of the upcoming community syncs:
## Join the Community on Slack
We have a [Slack channel](https://join.slack.com/t/apachextablei-yoi8504/shared_invite/zt-2y9hqskhv-ZfSwoxzq~PTJlWGj0V1sQw) that you can join for help with any questions, issues, design choices, announcements, etc.

## Contribution Guidelines

### Getting Started

- Fork the repo and create a feature branch from `main`.
- Open a pull request (PR) against the main branch with a clear summary of your changes.
- Use descriptive commit messages.
- Write or update unit tests where applicable.
- Refer to the [README](https://github.com/apache/incubator-xtable/blob/main/README.md) for more detailed setup instructions.

### Pull Request Review Process

- All PRs are reviewed by project committers.
- Review comments may request changes, please try to update the PR within a reasonable time.
- We aim to keep the review loop tight and collaborative.

### Handling Stale Pull Requests

- To keep development moving and reduce backlog, PRs with no activity for many days may be marked as stale.
- A committer may pick up a stale PR, incorporate necessary changes (including rebasing or completing the implementation), and merge it.
- Attribution to the original author will always be preserved in the commit history. This helps prevent good contributions from getting lost due to inactivity, while staying aligned with Apache’s community-first philosophy.


## Recordings of the Community Calls
Find date-wise recordings here.
Expand Down