Skip to content

StackTraceStringResolver uses instance after recycling #1380

Closed
@vy

Description

@vy

StackTraceStringResolver contains the following lines:

@Override
public void resolve(
        final Throwable throwable,
        final JsonWriter jsonWriter) {
    final TruncatingBufferedPrintWriter srcWriter = srcWriterRecycler.acquire();
    try {
        throwable.printStackTrace(srcWriter);
        final TruncatingBufferedPrintWriter dstWriter = truncate(srcWriter);
        jsonWriter.writeString(dstWriter);
    } finally {
        srcWriterRecycler.release(srcWriter);
    }
}

private TruncatingBufferedPrintWriter truncate(
        final TruncatingBufferedPrintWriter srcWriter) {

    // ...

    // Allocate temporary buffers and truncate the input.
    final TruncatingBufferedPrintWriter dstWriter =
            dstWriterRecycler.acquire();
    try {
        // ...
    } finally {
        dstWriterRecycler.release(dstWriter);
    }
    return dstWriter;

}

dstWriter created in truncate() recycled there, though used in resolve() later on.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions