[MarkerResolver] Expose parents as a list under field name parents
#1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-throw with serialized event This should make it a little easier for people running tests to see if (or rather how) they have screwed up the JSON formatting.
eherot
force-pushed
the
expose-marker-parents
branch
from
8d54356 to
2005bc5
Compare
eherot
commented
Mar 20, 2023
...plate-json-test/src/test/java/org/apache/logging/log4j/layout/template/json/TestHelpers.java
Show resolved
Hide resolved
qschmick
approved these changes
Mar 21, 2023
|
Thanks so much for the contribution, @eherot! I will pick this up sometime today. |
anoyes-inv
approved these changes
Mar 21, 2023
|
@eherot, LGTM, merged. There are some minor changes that needs to be done. This also needs to be ported to |
vy
added a commit
that referenced
this pull request
Mar 21, 2023
vy
added a commit
that referenced
this pull request
Mar 21, 2023
vy
pushed a commit
that referenced
this pull request
Mar 21, 2023
theit
pushed a commit
to theit/logging-log4j2
that referenced
this pull request
May 30, 2023
theit
pushed a commit
to theit/logging-log4j2
that referenced
this pull request
May 30, 2023
theit
pushed a commit
to theit/logging-log4j2
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PatternLayout can display the marker's parents with
%marker. I thought it would be handy if the JSON Template Layout also had that capability.Also added tests for the existing MarkerResolver since there weren't any
Additionally:
Slightly modified the TestHelper to catch exceptions in
readJsonand re-throw with the serialized event, to make it a little easier to debug JSON formatting issues.Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply runspotless:applyand retry)src/changelog/.2.x.xdirectory