Fix Log4jFixedFormatter buffer length
#1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
reviewed
Apr 11, 2023
log4j-core/src/main/java/org/apache/logging/log4j/core/util/datetime/FixedDateFormat.java
Show resolved
Hide resolved
ppkarwasz
force-pushed
the
jtl-buffer-length
branch
from
171234d to
880e8de
Compare
ppkarwasz
force-pushed
the
jtl-buffer-length
branch
from
880e8de to
1c250b0
Compare
vy
reviewed
Aug 3, 2023
Comment on lines
+514
to
+516
| * Returns the length of the resulting formatted date and time strings. | ||
| * | ||
| * @return the length of the resulting formatted date and time strings |
There was a problem hiding this comment.
This description is not correct, otherwise we won't need to double the size of the buffer in InstantFormatter.
There was a problem hiding this comment.
Right, I should add "in the ROOT locale" (which is basically English, but less anglocentric).
There was a problem hiding this comment.
I will appreciate that. Maybe also a note on "if you want to determine the max. length independent of the used locale, you better multiply this number by 2".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1418 .
The buffer length in
Log4jFixedFormatterwas computed base on the length of the pattern. Now it is the double of the real length of a formatted date (in the English locale).At the same time this migrates the
FastDateFormattertests to JUnit 5.