Improve warning message if multi-release JARs are not supported #1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up from my pervious PR [1]. Unfortunatly, it only occured to me after it was merged that the warning message is incomplete. In my case it was not the runtime environment which did not support multi-release JARs, but the build system. This adjusts the message accordingly. 1: apache#1760
ppkarwasz
approved these changes
Oct 5, 2023
ppkarwasz
pushed a commit
that referenced
this pull request
Oct 5, 2023
vy
pushed a commit
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from my pervious PR [1]. Unfortunatly, it only occured to me after it was merged that the warning message is incomplete. In my case it was not the runtime environment which did not support multi-release JARs, but the build system. This adjusts the message accordingly.
1: #1760