[chore] improve error handling when invoking 'start' twice #418
+112
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
force-pushed
the
double-start-error-handling
branch
from
f4cea47 to
8e9c491
Compare
pjfanning
reviewed
Apr 25, 2025
| @@ -0,0 +1,54 @@ | |||
| /* | |||
| * Licensed to the Apache Software Foundation (ASF) under one or more | |||
| * license agreements; and to You under the Apache License, version 2.0: | |||
There was a problem hiding this comment.
Could you switch the source header to the standard ASF header? https://github.com/apache/pekko/blob/main/project/AddMetaInfLicenseFiles.scala#L1-L16
Currently, when you run `start` twice with the same config, it will start the PekkoManagement extension once and return the same `Uri`. This is a convenient 'idempotence'. However, previously this would silently ignore the second invocation if the parameters of the two calls were different, leading to a race condition. The change in this commit adds error handling so that if the second invocation uses different parameters, it will fail the second call with a sensible error message.
raboof
force-pushed
the
double-start-error-handling
branch
from
8e9c491 to
e484ab1
Compare
|
@raboof if you have time, could you back port this to 1.0.x branch? |
raboof
added a commit
to raboof/pekko-management
that referenced
this pull request
Apr 26, 2025
Currently, when you run `start` twice with the same config, it will start the PekkoManagement extension once and return the same `Uri`. This is a convenient 'idempotence'. However, previously this would silently ignore the second invocation if the parameters of the two calls were different, leading to a race condition. The change in this commit adds error handling so that if the second invocation uses different parameters, it will fail the second call with a sensible error message.
|
Sure, #420 |
pjfanning
pushed a commit
to raboof/pekko-management
that referenced
this pull request
Apr 28, 2025
Currently, when you run `start` twice with the same config, it will start the PekkoManagement extension once and return the same `Uri`. This is a convenient 'idempotence'. However, previously this would silently ignore the second invocation if the parameters of the two calls were different, leading to a race condition. The change in this commit adds error handling so that if the second invocation uses different parameters, it will fail the second call with a sensible error message.
pjfanning
pushed a commit
that referenced
this pull request
May 2, 2025
Currently, when you run `start` twice with the same config, it will start the PekkoManagement extension once and return the same `Uri`. This is a convenient 'idempotence'. However, previously this would silently ignore the second invocation if the parameters of the two calls were different, leading to a race condition. The change in this commit adds error handling so that if the second invocation uses different parameters, it will fail the second call with a sensible error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you run
starttwice with the same config, it will start the PekkoManagement extension once and return the sameUri. This is a convenient 'idempotence'. However, previously this would silently ignore the second invocation if the parameters of the two calls were different, leading to a race condition.The change in this commit adds error handling so that if the second invocation uses different parameters, it will fail the second call with a sensible error message.