Skip to content

[WIP] JDBC: Static SQL #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

singhpk234
Copy link
Contributor

@singhpk234 singhpk234 commented Jun 6, 2025

About the change

Static SQL is preferred over runtime SQL generation

  • This change gets rid of almost all runtime SQL generation barring the IN query where the size is not available until runtime.
  • Move the realm_id to the model to simplify the parameter feeding to the PreparedQuery
  • Completely gets rid of QueryGenerator class and it's tests

Pending

  • Refactor the databaseType conversions to abstract it away from the mode
  • Refactor the DataSourceOperations to incorporate the databaseType presently it kind of is spread to MetastoreManagerFactory
  • Find better ways to bind the query currently we are using the ordered DS to feed it to the query.

Testing

Existing test pass

@singhpk234 singhpk234 force-pushed the fix/prep-statement branch from de4e7ad to 865fddf Compare June 6, 2025 21:19
@singhpk234 singhpk234 force-pushed the fix/prep-statement branch from 845b698 to 09c32a3 Compare June 6, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant