Introduce idempotency records schema and Postgres-backed IdempotencyStore #3205
Conversation
| public Optional<IdempotencyRecord> getExisting() { return existing; } | ||
| } | ||
|
|
||
| ReserveResult reserve( |
There was a problem hiding this comment.
Please add javadoc. This is a key interface, so describing API contracts is important, especially concurrency and consistency expectations.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.polaris.idempotency; |
There was a problem hiding this comment.
Since the obvious intention in this interface is to provide persistent storage for idempotency records, I suppose putting the new SPI interface into org.apache.polaris.core.persistence might be preferable.
There was a problem hiding this comment.
Thanks for the suggestion! I have moved new SPI interface to org.apache.polaris.core.persistence
|
@huaxingao : Thanks for starting the implementation for idempoten retries in Polaris! Since this is a major new core feature, please mention this PR on the |
|
Thanks @dimas-b for the comments! I’ll send out a discussion email to the dev mailing list shortly. |
2 participants
This PR adds the persistence foundation for REST idempotency in Polaris:
Defines an
idempotency_recordstable (Postgres) with key, binding, liveness, and finalization fields.Introduces a storage‑agnostic
IdempotencyRecordmodel andIdempotencyStoreSPI in polaris-core.Implements
PostgresIdempotencyStoreinpolaris-relational-jdbcChecklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)