Skip to content

Conversation

@MonkeyCanCode
Copy link
Contributor

@MonkeyCanCode MonkeyCanCode commented Dec 6, 2025

Since org.testcontainers:testcontainers 2.x, they changed dependency from org.testcontainers:<dependency> to org.testcontainers:testcontainers-<dependency>. For reference:

psql:

junit-jupiter

Checklist

  • 🛡️ Don't disclose security issues! (contact [email protected])
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

singhpk234
singhpk234 previously approved these changes Dec 6, 2025
Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MonkeyCanCode !

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Dec 6, 2025
flyrain
flyrain previously approved these changes Dec 6, 2025
Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@MonkeyCanCode MonkeyCanCode dismissed stale reviews from flyrain and singhpk234 via 95a2441 December 6, 2025 23:14
@MonkeyCanCode MonkeyCanCode changed the title Change org.testcontainers:postgresql to org.testcontainers:testcontai… Change org.testcontainers:<dep> to org.testcontainers:testcontainers-<dep> Dec 6, 2025
@MonkeyCanCode MonkeyCanCode merged commit a997e5a into apache:main Dec 9, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants