Skip to content

[ISSUE #219] Support to enable tls through configuration file #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

liuliuzo
Copy link
Contributor

@liuliuzo liuliuzo commented Feb 7, 2021

What is the purpose of the change

Support to enable tls through configuration file. This feature can enable:

  • each Producer and consumer can configuration tls for different MQ cluster

Brief changelog

add enable tls option by spring placeholder in annotations

  • ExtRocketMQConsumerConfiguration
  • ExtRocketMQTemplateConfiguration
  • RocketMQMessageListener
  • RocketMQProperties for default producer tls configuration
    ###add new tls logic code
  • ExtConsumerResetConfiguration
  • ExtProducerResetConfiguration
  • ListenerContainerConfiguration
  • RocketMQAutoConfiguration
  • DefaultRocketMQListenerContainer

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #219] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • [] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [] If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liuliuzo liuliuzo changed the title Feature/issue #219 support configable tls [ISSUE #219] Support to enable tls through configuration file Feb 7, 2021
Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there is no need to add a separate sample.

@liuliuzo
Copy link
Contributor Author

I have removed.

@RongtongJin
Copy link
Contributor

I have removed.

It would be better to remove it from other samples because this configuration item is not required and commonly used.

@liuliuzo
Copy link
Contributor Author

liuliuzo commented Mar 14, 2021

Hi @RongtongJin ,do i need merge from the master branch to update the latest version ,then submit again ? for security reason our company really need this feature

@liuliuzo
Copy link
Contributor Author

liuliuzo commented Jul 5, 2021

@RongtongJin 大佬这个还能merge 进去吗?或者需要同步一下master?

@zongtanghu
Copy link

There exists some codes conflicts, please resolve the codes conflicts in you local enviroments please firstly. @liuliuzo

@liuliuzo
Copy link
Contributor Author

@zongtanghu conflicts has been solved thx for review

@liuliuzo
Copy link
Contributor Author

liuliuzo commented Sep 8, 2021

@zongtanghu ,我们同一个应用在订阅不同ROCKETMQ集群的时候,跨中心的集群访问需要开启TLS,不跨中心的集群不需要使用TLS,是有这个需求的。

@vongosling
Copy link
Member

@liuliuzo Could you help to sign up your case? #234

@vongosling vongosling linked an issue Sep 8, 2021 that may be closed by this pull request
@vongosling vongosling merged commit 31ba77b into apache:master Sep 8, 2021
@vongosling vongosling added this to the 2.2.2 milestone Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support to enable tls through configuration file
4 participants