-
Notifications
You must be signed in to change notification settings - Fork 926
[ISSUE #219] Support to enable tls through configuration file #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #219] Support to enable tls through configuration file #347
Conversation
merge from rocketmq spring
chore(pom):update rocket-spring samples version (apache#336)
rocketmq-spring-boot-samples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that there is no need to add a separate sample.
…elete separate samples
I have removed. |
It would be better to remove it from other samples because this configuration item is not required and commonly used. |
Hi @RongtongJin ,do i need merge from the master branch to update the latest version ,then submit again ? for security reason our company really need this feature |
@RongtongJin 大佬这个还能merge 进去吗?或者需要同步一下master? |
There exists some codes conflicts, please resolve the codes conflicts in you local enviroments please firstly. @liuliuzo |
@zongtanghu conflicts has been solved thx for review |
@zongtanghu ,我们同一个应用在订阅不同ROCKETMQ集群的时候,跨中心的集群访问需要开启TLS,不跨中心的集群不需要使用TLS,是有这个需求的。 |
What is the purpose of the change
Support to enable tls through configuration file. This feature can enable:
Brief changelog
add enable tls option by spring placeholder in annotations
###add new tls logic code
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #219] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.