Skip to content

Remove unnecessary catch blocks and log statements in syncSendGrpcMessage #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025
Merged

Remove unnecessary catch blocks and log statements in syncSendGrpcMessage #711

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08e3233
Remove unnecessary catch blocks and log statements.
RongtongJin Mar 12, 2025
32bf105
Optimize log output
RongtongJin Mar 13, 2025
cc36cfe
Optimize log output
RongtongJin Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions ...ent-spring-boot/src/main/java/org/apache/rocketmq/client/core/RocketMQClientTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,21 +221,14 @@ public SendReceipt syncSendNormalMessage(String destination, byte[] payload) {
*/
public SendReceipt syncSendGrpcMessage(String destination, Message<?> message, Duration messageDelayTime, String messageGroup) {
if (Objects.isNull(message) || Objects.isNull(message.getPayload())) {
log.error("send request message failed. destination:{}, message is null ", destination);
throw new IllegalArgumentException("`message` and `message.payload` cannot be null");
}
SendReceipt sendReceipt = null;
try {
org.apache.rocketmq.client.apis.message.Message rocketMsg = this.createRocketMQMessage(destination, message, messageDelayTime, messageGroup);
Producer grpcProducer = this.getProducer();
try {
sendReceipt = grpcProducer.send(rocketMsg);
log.info("Send message successfully, messageId={}", sendReceipt.getMessageId());
} catch (Throwable t) {
log.error("Failed to send message", t);
}
sendReceipt = grpcProducer.send(rocketMsg);
} catch (Exception e) {
log.error("send request message failed. destination:{}, message:{} ", destination, message);
throw new MessagingException(e.getMessage(), e);
}
return sendReceipt;
Expand Down Expand Up @@ -311,7 +304,6 @@ public CompletableFuture<SendReceipt> asyncSendDelayMessage(String destination,

public CompletableFuture<SendReceipt> asyncSend(String destination, Message<?> message, Duration messageDelayTime, String messageGroup, CompletableFuture<SendReceipt> future) {
if (Objects.isNull(message) || Objects.isNull(message.getPayload())) {
log.error("send request message failed. destination:{}, message is null ", destination);
throw new IllegalArgumentException("`message` and `message.payload` cannot be null");
}
Producer grpcProducer = this.getProducer();
Expand All @@ -329,7 +321,6 @@ public CompletableFuture<SendReceipt> asyncSend(String destination, Message<?> m
});
}
} catch (Exception e) {
log.error("send request message failed. destination:{}, message:{} ", destination, message);
throw new MessagingException(e.getMessage(), e);
}
return future0;
Expand Down Expand Up @@ -358,7 +349,6 @@ public Pair<SendReceipt, Transaction> sendMessageInTransaction(String destinatio
*/
public Pair<SendReceipt, Transaction> sendTransactionMessage(String destination, Message<?> message) {
if (Objects.isNull(message) || Objects.isNull(message.getPayload())) {
log.error("send request message failed. destination:{}, message is null ", destination);
throw new IllegalArgumentException("`message` and `message.payload` cannot be null");
}
final SendReceipt sendReceipt;
Expand All @@ -368,9 +358,7 @@ public Pair<SendReceipt, Transaction> sendTransactionMessage(String destination,
try {
transaction = grpcProducer.beginTransaction();
sendReceipt = grpcProducer.send(rocketMsg, transaction);
log.info("Send transaction message successfully, messageId={}", sendReceipt.getMessageId());
} catch (ClientException e) {
log.error("send request message failed. destination:{}, message:{} ", destination, message);
throw new RuntimeException(e);
}
return new Pair<>(sendReceipt, transaction);
Expand Down
Loading