Skip to content

Fix npe two streams & fix joinwindow's production donot be conducted by mainpipeline's following stages #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2021
Merged

Fix npe two streams & fix joinwindow's production donot be conducted by mainpipeline's following stages #104

merged 2 commits into from
Dec 28, 2021

Conversation

lizhiboo
Copy link
Contributor

  1. fix npe in two streams case. set otherPipelineBuilders.
  2. init otherPipelines at first to avoid miss mainPipeline's following stages after windowStage.

@lizhiboo lizhiboo mentioned this pull request Dec 24, 2021
Closed
@duhenglucky duhenglucky merged commit e57a360 into apache:main Dec 28, 2021
@duhenglucky duhenglucky linked an issue Dec 28, 2021 that may be closed by this pull request
Fix npe two streams & fix joinwindow's production donot be conducted by mainpipeline's following stages #107
Closed
ni-ze pushed a commit to ni-ze/rocketmq-streams that referenced this pull request Oct 7, 2022
@lizhiboo
Fix npe two streams & fix joinwindow's production donot be conducted …
0c9a8ce 
…by mainpipeline's following stages (apache#104)

* fix NPE in two streams case

* init otherPipeline first to avoid config be overwrote, then join window's production will be conduct by mainPipeline's following stages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duhenglucky duhenglucky duhenglucky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix npe two streams & fix joinwindow's production donot be conducted by mainpipeline's following stages
2 participants
@lizhiboo @duhenglucky