Skip to content

Use shade plugin to hide dependencies #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Conversation

totalo
Copy link
Member

@totalo totalo commented Jul 13, 2022

Fixed #165

@ni-ze
Copy link
Contributor

ni-ze commented Jul 18, 2022

@totalo Great patch!

@ni-ze
Copy link
Contributor

ni-ze commented Jul 18, 2022

However this pr do not resolve dependency conflicts, because dependency of RocketMQ-Streams can be depend by application which depend on RocketMQ-Streams.

@totalo
Copy link
Member Author

totalo commented Jul 18, 2022

However this pr do not resolve dependency conflicts, because dependency of RocketMQ-Streams can be depend by application which depend on RocketMQ-Streams.

ok, i'll check it.

@totalo totalo marked this pull request as draft July 20, 2022 04:21
@totalo totalo marked this pull request as ready for review July 21, 2022 14:47
@totalo
Copy link
Member Author

totalo commented Jul 22, 2022

hi @ni-ze, plz check it.thanks

@ni-ze
Copy link
Contributor

ni-ze commented Jul 23, 2022

hi @ni-ze, plz check it.thanks

I check it,example and application depend on rocketmq-client works well.

@totalo
Copy link
Member Author

totalo commented Aug 11, 2022

hi @ni-ze, plz check it.thanks

I check it,example and application depend on rocketmq-client works well.

@ni-ze Hi, is there any problem with this?

@duhenglucky duhenglucky merged commit 0c85c97 into apache:main Aug 24, 2022
@totalo totalo deleted the fix-165 branch August 26, 2022 06:26
ni-ze pushed a commit to ni-ze/rocketmq-streams that referenced this pull request Oct 7, 2022
* Use shade plugin to hide dependencies

* Use shade plugin to hide dependencies

* update shade plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is dependency conflict if application and RocketMQ Streams has same dependency.
4 participants