-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[ISSUE #5883] Dledger commit log should override the getData #5879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #5883] Dledger commit log should override the getData #5879
Conversation
Change-Id: I665c5b9d7e96c5b7ccd035b32272be7223d7f454
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! It would be better to create an associated issue like other pull request.
store/src/test/java/org/apache/rocketmq/store/timer/TimerMessageStoreTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #5879 +/- ##
=============================================
+ Coverage 42.43% 43.20% +0.76%
- Complexity 8277 8852 +575
=============================================
Files 1066 1094 +28
Lines 73671 77204 +3533
Branches 9630 10073 +443
=============================================
+ Hits 31261 33353 +2092
- Misses 38460 39676 +1216
- Partials 3950 4175 +225
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
store/src/test/java/org/apache/rocketmq/store/timer/TimerMessageStoreTest.java
Outdated
Show resolved
Hide resolved
Change-Id: I5aa348ab17977ce1f0e080f7801b28797ef82af9
Change-Id: I665c5b9d7e96c5b7ccd035b32272be7223d7f454
Make sure set the target branch to
develop
What is the purpose of the change
The dledger commit log currently did not override the new getData method, while using dledger mode it will cause the read failed. In timer store it will get commit log using this method.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.