Skip to content

[ISSUE #5883] Dledger commit log should override the getData #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

absolute8511
Copy link
Contributor

@absolute8511 absolute8511 commented Jan 13, 2023

Change-Id: I665c5b9d7e96c5b7ccd035b32272be7223d7f454

Make sure set the target branch to develop

What is the purpose of the change

The dledger commit log currently did not override the new getData method, while using dledger mode it will cause the read failed. In timer store it will get commit log using this method.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Change-Id: I665c5b9d7e96c5b7ccd035b32272be7223d7f454
Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It would be better to create an associated issue like other pull request.

@absolute8511 absolute8511 changed the title fix: dledger commit log should override the getData [ISSUE #5883] fix: dledger commit log should override the getData Jan 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Merging #5879 (804d928) into develop (5b64ffc) will increase coverage by 0.76%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #5879      +/-   ##
=============================================
+ Coverage      42.43%   43.20%   +0.76%     
- Complexity      8277     8852     +575     
=============================================
  Files           1066     1094      +28     
  Lines          73671    77204    +3533     
  Branches        9630    10073     +443     
=============================================
+ Hits           31261    33353    +2092     
- Misses         38460    39676    +1216     
- Partials        3950     4175     +225     
Impacted Files Coverage Δ
...pache/rocketmq/store/dledger/DLedgerCommitLog.java 76.81% <0.00%> (-1.59%) ⬇️
.../rocketmq/common/utils/ConcurrentHashMapUtils.java 58.33% <0.00%> (-8.34%) ⬇️
.../rocketmq/client/producer/RequestFutureHolder.java 81.39% <0.00%> (-6.98%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 46.50% <0.00%> (-6.41%) ⬇️
.../org/apache/rocketmq/remoting/netty/TlsHelper.java 71.57% <0.00%> (-6.32%) ⬇️
.../apache/rocketmq/remoting/protocol/EpochEntry.java 25.00% <0.00%> (-4.63%) ⬇️
...controller/impl/DefaultBrokerHeartbeatManager.java 82.27% <0.00%> (-3.80%) ⬇️
...a/org/apache/rocketmq/broker/BrokerController.java 43.14% <0.00%> (-3.01%) ⬇️
...he/rocketmq/proxy/common/MessageReceiptHandle.java 72.54% <0.00%> (-2.89%) ⬇️
...ketmq/proxy/grpc/v2/channel/GrpcClientChannel.java 49.07% <0.00%> (-2.78%) ⬇️
... and 138 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ni-ze
ni-ze previously approved these changes Jan 17, 2023
mxsm
mxsm previously approved these changes Jan 18, 2023
Change-Id: I5aa348ab17977ce1f0e080f7801b28797ef82af9
@absolute8511 absolute8511 dismissed stale reviews from mxsm and ni-ze via f23ecfc January 28, 2023 04:03
@RongtongJin RongtongJin changed the title [ISSUE #5883] fix: dledger commit log should override the getData [ISSUE #5883] Dledger commit log should override the getData Mar 6, 2023
RongtongJin
RongtongJin previously approved these changes Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dledger commit log currently did not override the new getData method, while using dledger mode it will cause the read failed.
5 participants