Skip to content

Conversation

@bee0511
Copy link
Contributor

@bee0511 bee0511 commented Oct 22, 2025

Fixes #2485 .

Changes proposed in this pull request:

  • Modified getErrorMessage to isValidErrorMessage() method in ElasticJobExecutorTest to accept both possible orderings of ConcurrentHashMap entries ({0=..., 1=...} or {1=..., 0=...})
  • This fix eliminates the flaky test failure caused by non-deterministic HashMap iteration order

Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The code style is handled in a separate Maven profile. The PR did not pass the code formatting validation. You can execute first ./mvnw spotless:apply -Pcheck -T1C. Then execute ./mvnw checkstyle:check -Pcheck -T1C to manually adjust to repair the CI.

@bee0511
Copy link
Contributor Author

bee0511 commented Oct 25, 2025

  • The code style is handled in a separate Maven profile. The PR did not pass the code formatting validation. You can execute first ./mvnw spotless:apply -Pcheck -T1C. Then execute ./mvnw checkstyle:check -Pcheck -T1C to manually adjust to repair the CI.

Hi @linghengqian,
I have fixed the checkstyle issue and the CI has passed.

@linghengqian linghengqian added this to the 3.1.0 milestone Oct 25, 2025
Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linghengqian linghengqian merged commit 4d13c86 into apache:master Oct 25, 2025
15 checks passed
@bee0511 bee0511 deleted the fix-elasticjob branch October 25, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test in ElasticJobExecutorTest due to HashMap ordering

2 participants