[SPARK-43205][DOC] identifier clause docs #42506
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srielau
force-pushed
the
SPARK-43205-3.5-IDENTIFIER-clause-docs
branch
from
33ad6bc to
454c33a
Compare
Contributor
Author
|
@cloud-fan For your review |
srielau
changed the title
cloud-fan
approved these changes
Aug 18, 2023
Contributor
|
thanks, merging to master/3.5! |
cloud-fan
pushed a commit
that referenced
this pull request
Aug 18, 2023
### What changes were proposed in this pull request? Document the IDENTIFIER() clause ### Why are the changes needed? Docs are good! ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? <!-- <img width="892" alt="Screenshot 2023-08-15 at 4 26 27 PM" src="https://github.com/apache/spark/assets/3514644/6ce43330-668e-4c84-b72b-bf1e2679d736"> If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. --> See attached <img width="892" alt="Screenshot 2023-08-15 at 4 26 27 PM" src="https://github.com/apache/spark/assets/3514644/55823375-8d1a-4473-bf19-74796d273416"> <img width="747" alt="Screenshot 2023-08-15 at 4 45 23 PM" src="https://github.com/apache/spark/assets/3514644/0ee852a9-6a11-4c87-bed9-43531c55fc31"> Closes #42506 from srielau/SPARK-43205-3.5-IDENTIFIER-clause-docs. Authored-by: srielau <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
### What changes were proposed in this pull request? Document the IDENTIFIER() clause ### Why are the changes needed? Docs are good! ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? <!-- <img width="892" alt="Screenshot 2023-08-15 at 4 26 27 PM" src="https://github.com/apache/spark/assets/3514644/6ce43330-668e-4c84-b72b-bf1e2679d736"> If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. --> See attached <img width="892" alt="Screenshot 2023-08-15 at 4 26 27 PM" src="https://github.com/apache/spark/assets/3514644/55823375-8d1a-4473-bf19-74796d273416"> <img width="747" alt="Screenshot 2023-08-15 at 4 45 23 PM" src="https://github.com/apache/spark/assets/3514644/0ee852a9-6a11-4c87-bed9-43531c55fc31"> Closes apache#42506 from srielau/SPARK-43205-3.5-IDENTIFIER-clause-docs. Authored-by: srielau <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 7786d0b) Signed-off-by: Wenchen Fan <[email protected]>
LuciferYang
pushed a commit
that referenced
this pull request
Dec 7, 2024
### What changes were proposed in this pull request? This PR aims to add `IDENTIFIER clause` page to `menu-sql.yaml` for Apache Spark 3.5.4. ### Why are the changes needed? This was missed at SPARK-43205 (Apache Spark 3.5.0). - #42506 ### Does this PR introduce _any_ user-facing change? **BEFORE**  **AFTER**  ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49097 from dongjoon-hyun/SPARK-50514. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
LuciferYang
pushed a commit
that referenced
this pull request
Dec 7, 2024
### What changes were proposed in this pull request? This PR aims to add `IDENTIFIER clause` page to `menu-sql.yaml` for Apache Spark 3.5.4. ### Why are the changes needed? This was missed at SPARK-43205 (Apache Spark 3.5.0). - #42506 ### Does this PR introduce _any_ user-facing change? **BEFORE**  **AFTER**  ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49097 from dongjoon-hyun/SPARK-50514. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: yangjie01 <[email protected]> (cherry picked from commit 28766d4) Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Document the IDENTIFIER() clause
Why are the changes needed?
Docs are good!
Does this PR introduce any user-facing change?
How was this patch tested?
See attached
