[SPARK-44289][FOLLOWUP] Cleanup doctest #42552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Aug 18, 2023
|
merged to master |
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
### What changes were proposed in this pull request? This is followup for apache#42533 to remove meaningless import ### Why are the changes needed? import numpy is not needed for doctest. ### Does this PR introduce _any_ user-facing change? This impacts to user-facing documents, so it's sort of user-facing cleanup. ### How was this patch tested? The existing CI should pass Closes apache#42552 from itholic/test-followup. Authored-by: itholic <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? This is followup for apache#42533 to remove meaningless import ### Why are the changes needed? import numpy is not needed for doctest. ### Does this PR introduce _any_ user-facing change? This impacts to user-facing documents, so it's sort of user-facing cleanup. ### How was this patch tested? The existing CI should pass Closes apache#42552 from itholic/test-followup. Authored-by: itholic <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is followup for #42533 to remove meaningless import
Why are the changes needed?
import numpy is not needed for doctest.
Does this PR introduce any user-facing change?
This impacts to user-facing documents, so it's sort of user-facing cleanup.
How was this patch tested?
The existing CI should pass