[SPARK-52345][SQL] Fix NULL behavior in scripting conditions #51047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan @dejankrak-db @miland-db @dusantism-db please review |
dusantism-db
approved these changes
May 29, 2025
cloud-fan
approved these changes
May 29, 2025
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
May 29, 2025
### What changes were proposed in this pull request? `NULL` is a valid Boolean "value" in SQL. Scripting engine is not properly handling cases when conditions (in if-else, case, while, repeat statements) returned NULL. Scripting engine throws an exception in such cases, stating that the NULL is an invalid value. Scripting engine should consider such NULLs as a False Boolean value. ### Why are the changes needed? Fixes the wrong behavior in condition evaluation for scripting statements. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Old and new unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #51047 from davidm-db/scripting_conditions_null_fix. Authored-by: David Milicevic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 2367f58) Signed-off-by: Wenchen Fan <[email protected]>
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
### What changes were proposed in this pull request? `NULL` is a valid Boolean "value" in SQL. Scripting engine is not properly handling cases when conditions (in if-else, case, while, repeat statements) returned NULL. Scripting engine throws an exception in such cases, stating that the NULL is an invalid value. Scripting engine should consider such NULLs as a False Boolean value. ### Why are the changes needed? Fixes the wrong behavior in condition evaluation for scripting statements. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Old and new unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#51047 from davidm-db/scripting_conditions_null_fix. Authored-by: David Milicevic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
NULLis a valid Boolean "value" in SQL. Scripting engine is not properly handling cases when conditions (in if-else, case, while, repeat statements) returned NULL.Scripting engine throws an exception in such cases, stating that the NULL is an invalid value.
Scripting engine should consider such NULLs as a False Boolean value.
Why are the changes needed?
Fixes the wrong behavior in condition evaluation for scripting statements.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Old and new unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.