Skip to content

Conversation

@manojshetty2004
Copy link

@manojshetty2004 manojshetty2004 commented Dec 21, 2025

User description

SUMMARY

Normalizes typography in widget settings/sidebar panels to improve visual hierarchy and readability.

Inner sub-section titles previously relied on varying font weights, which created visual noise. This change uses a single, consistent font weight and spacing to establish hierarchy more clearly, without altering layout or behavior.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  1. Open Explore view.
  2. Open widget settings / sidebar panels.
  3. Verify that inner sub-section titles use a consistent font weight.
  4. Confirm improved readability and spacing without layout changes.

ADDITIONAL INFORMATION


CodeAnt-AI Description

Normalize typography in widget settings panels

What Changed

  • Sub-section headings in widget settings and sidebar now use a consistent medium font weight
  • Spacing below those headings increased to standard grid spacing for clearer separation
  • Visible font size remains unchanged

Impact

✅ Clearer widget subsection titles
✅ More consistent sidebar typography
✅ Improved readability in Explore settings

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Dec 21, 2025

Code Review Agent Run #c58012

Actionable Suggestions - 0
Additional Suggestions - 2
  • superset-frontend/packages/superset-ui-chart-controls/src/components/ControlSubSectionHeader.tsx - 2
    • Theme Migration · Line 23-23
      Theme property migration from fontWeightStrong to typography.weights.medium follows AGENTS.md guidelines to prefer antd theming tokens over legacy ones.
    • Theme Migration · Line 24-24
      Theme property migration from sizeUnit to gridUnit * 2 follows AGENTS.md guidelines to prefer antd theming tokens over legacy ones.
Review Details
  • Files reviewed - 1 · Commit Range: 4a2e9fe..4a2e9fe
    • superset-frontend/packages/superset-ui-chart-controls/src/components/ControlSubSectionHeader.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the explore:design Related to the Explore UI/UX label Dec 21, 2025
@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai-for-open-source codeant-ai-for-open-source bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Dec 21, 2025
@codeant-ai-for-open-source
Copy link
Contributor

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review

  • Theme token mismatch
    The code now references theme.typography.weights.medium which may not exist in all theme shapes used across the repo (previously theme.fontWeightStrong was used). If the theme object doesn't include this path, the runtime value could be undefined and styling may break or regress. Verify the theme API and consider providing a safe fallback.

  • Spacing token consistency
    The change uses theme.gridUnit * 2 for margin-bottom while older code used theme.sizeUnit. Ensure using gridUnit is intentionally consistent across the codebase/themes to avoid spacing regressions in other components or themes that expect sizeUnit. Consider a fallback or centralize spacing tokens.

@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI finished reviewing your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

explore:design Related to the Explore UI/UX packages size/XS size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant