Skip to content

fix(deckgl): respect stroked toggle for polygon line width #36793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YousufFFFF wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(deckgl): respect stroked toggle for polygon line width #36793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/Polygon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ export const getLayer: GetLayerType<PolygonLayer> = function ({
getPolygon: getPointsFromPolygon,
getFillColor: colorScaler,
getLineColor: sc ? [sc.r, sc.g, sc.b, 255 * sc.a] : undefined,
getLineWidth: fd.line_width,
lineWidthMinPixels: fd.stroked ? fd.line_width : 0,
Copy link
Contributor

@bito-code-review bito-code-review bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect deck.gl property usage

Replacing getLineWidth with lineWidthMinPixels changes polygon outline behavior from setting the actual width to only enforcing a minimum pixel width. This can result in thinner lines than expected, especially when fd.line_width differs from the default. Other deck.gl layers in the codebase still use getLineWidth, and deck.gl docs confirm both properties exist but serve different purposes.

Code Review Run #dc0c85

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

  • Yes, avoid them

extruded: fd.extruded,
lineWidthUnits: fd.line_width_unit,
getElevation: (d: JsonObject) => getElevation(d, colorScaler),
Expand Down
Loading