docs: Update link for DASHBOARD_RBAC feature flag #36829
Conversation
update the link in the file to point to how to setup the feature flag. Previous page point to list of feature flag which may not make sene to new user on how to use feature flag
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Code Review Agent Run #d02e3eActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
codeant-ai-for-open-source
bot
added
the
size:XS
Nitpicks 🔍
|
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
| #### Making a Dashboard Public | ||
|
|
||
| 1. Add the `'DASHBOARD_RBAC': True` [Feature Flag](https://github.com/apache/superset/blob/master/RESOURCES/FEATURE_FLAGS.md) to `superset_config.py` | ||
| 1. Add the `'DASHBOARD_RBAC': True` [Feature Flag](/docs/configuration/configuring-superset#feature-flags) to `superset_config.py` |
There was a problem hiding this comment.
Suggestion: The inline fragment uses quotes and a colon within the prose which is easy to mis-copy and cause syntax mistakes; provide a clear inline code assignment alternative (single-line assignment) so readers can copy a minimal, correct statement. [possible bug]
Severity Level: Critical 🚨
| 1. Add the `'DASHBOARD_RBAC': True` [Feature Flag](/docs/configuration/configuring-superset#feature-flags) to `superset_config.py` | |
| 1. Alternatively, you can set the flag with a single-line assignment in `superset_config.py`: | |
| ```python | |
| FEATURE_FLAGS['DASHBOARD_RBAC'] = True |
<details>
<summary><b>Why it matters? ⭐ </b></summary>
A single-line assignment (FEATURE_FLAGS['DASHBOARD_RBAC'] = True) is a minimal, copy-pastable example that reduces ambiguity. It's helpful for users who already have FEATURE_FLAGS defined; the doc should still note the need to create the dict if it doesn't exist.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/docs/configuration/networking-settings.mdx
**Line:** 54:54
**Comment:**
*Possible Bug: The inline fragment uses quotes and a colon within the prose which is easy to mis-copy and cause syntax mistakes; provide a clear inline code assignment alternative (single-line assignment) so readers can copy a minimal, correct statement.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
|
CodeAnt AI finished reviewing your PR. |
1 participant
User description
update the link in the file to point to how to setup the feature flag. Previous page point to list of feature flag which may not make sene to new user on how to use feature flag
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
url update only
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CodeAnt-AI Description
docs: Point DASHBOARD_RBAC feature flag link to setup instructions
What Changed
'DASHBOARD_RBAC': Trueto superset_config.py and assign the Public role to dashboardsImpact
✅ Clearer feature flag setup✅ Fewer configuration errors for enabling public dashboards✅ Shorter time to find setup instructions💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.