Skip to content

chore(parameters): always render parameter templates#10099

Closed
leon-ape wants to merge 3 commits intomainfrom
support/always-rerender-parameters-template
Closed

chore(parameters): always render parameter templates#10099
leon-ape wants to merge 3 commits intomainfrom
support/always-rerender-parameters-template

Conversation

@leon-ape
Copy link
Copy Markdown
Contributor

No description provided.

@leon-ape leon-ape added this to the Release 1.2.0 milestone Mar 20, 2026
@leon-ape leon-ape requested a review from kizuna-lek March 20, 2026 07:15
@leon-ape leon-ape added the nopick Not auto cherry-pick when PR merged label Mar 20, 2026
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Mar 20, 2026
@apecloud-bot
Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

@leon-ape leon-ape force-pushed the support/always-rerender-parameters-template branch from 6ccaf72 to af59ad0 Compare March 20, 2026 07:20
@leon-ape leon-ape force-pushed the support/always-rerender-parameters-template branch from af59ad0 to f3a665e Compare March 20, 2026 07:24
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Mar 20, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 61.36364% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.79%. Comparing base (edbff89) to head (c0e9ec2).

Files with missing lines Patch % Lines
...ollers/parameters/componentparameter_controller.go 64.70% 4 Missing and 2 partials ⚠️
pkg/parameters/config_util.go 40.00% 5 Missing and 1 partial ⚠️
.../parameters/componentparameter_controller_utils.go 66.66% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10099      +/-   ##
==========================================
+ Coverage   51.60%   51.79%   +0.18%     
==========================================
  Files         525      525              
  Lines       58397    58257     -140     
==========================================
+ Hits        30138    30175      +37     
+ Misses      25305    25148     -157     
+ Partials     2954     2934      -20     
Flag Coverage Δ
unittests 51.79% <61.36%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Mar 20, 2026
@leon-ape leon-ape marked this pull request as ready for review March 20, 2026 08:39
@leon-ape leon-ape requested a review from a team as a code owner March 20, 2026 08:39
@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 20, 2026
@leon-ape leon-ape closed this Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants