chore(parameters): deprecate ParamConfigRenderer by moving bindings into ParametersDefinition#10100
Merged
chore(parameters): deprecate ParamConfigRenderer by moving bindings into ParametersDefinition#10100
Conversation
380704e to
2540387
Compare
77eea21 to
f6808af
Compare
f6808af to
3668bdc
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10100 +/- ##
==========================================
+ Coverage 51.60% 51.74% +0.13%
==========================================
Files 525 525
Lines 58397 58243 -154
==========================================
+ Hits 30138 30140 +2
+ Misses 25305 25148 -157
- Partials 2954 2955 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kizuna-lek
reviewed
Mar 25, 2026
kizuna-lek
approved these changes
Mar 25, 2026
cjc7373
approved these changes
Mar 26, 2026
Contributor
Author
|
/approve |
apecloud-bot
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR deprecates
ParamConfigRendererfrom the runtime path and moves component parameter binding metadata intoParametersDefinition.After this change:
ParametersDefinitionPayload/reRenderResourceTypesParamConfigRendererremains supported through fallback compatibility logicWhy
The old model had two main issues:
ParamConfigRendereradded an extra indirection in the runtime chain:Component -> ComponentDefinition -> ParamConfigRenderer -> ParametersDefinitionconditional rerendering depended on limited trigger metadata, while templates actually rendered from live component state, which could make final config depend on event order instead of current state.
This PR simplifies the model and makes config rendering behave more like a normal reconcile loop.
Main Changes
Added binding metadata to
ParametersDefinition:componentDefserviceVersiontemplateNamefileNamefileFormatConfigChanged runtime resolution from:
Component -> ComponentDefinition -> ParamConfigRenderer -> ParametersDefinitionto:
Component -> ComponentDefinition -> matched ParametersDefinitionsRemoved conditional rerender gating and always rerender the base template before applying parameter patches
Removed runtime dependency on
Payload/reRenderResourceTypesMade
ComponentParameterreact directly toComponentchanges by watchingComponentand comparing appliedComponent.GenerationRemoved the legacy
ParamConfigRenderercontroller from runtime registrationCompatibility
Backward compatibility is preserved.
ParamConfigRendererare supported through fallbackParametersDefinitionbindingsPDand others still come from legacyPCR, runtime merges them by filePDwinsOther compatibility notes:
ParamConfigRenderer.status.phaseParamConfigRendererAPI/CRD is retained and marked deprecatedTests
Added and updated coverage for:
ParametersDefinitionbinding resolutionnew PD + legacy PCRresolutionPDoverrides legacyPCRPCRnot breaking fallbackAlso tightened controller test fixtures to avoid cache timing races and flaky
ComponentParameter not foundfailures.Follow-up
This PR keeps the deprecated
ParamConfigRendererAPI only for compatibility.A later cleanup PR can remove the remaining compatibility surface after addon migration is complete.