feat(ops): add configurable DeleteRestoreCR option for rebuild#10110
Closed
destinyoooo wants to merge 1 commit intoapecloud:mainfrom
Closed
feat(ops): add configurable DeleteRestoreCR option for rebuild#10110destinyoooo wants to merge 1 commit intoapecloud:mainfrom
destinyoooo wants to merge 1 commit intoapecloud:mainfrom
Conversation
Collaborator
|
Auto Cherry-pick Instructions |
Contributor
|
hi @destinyoooo, what's the purpose of this PR? now, the restore resource get automatically cleaned up after the ops is deleted. |
Author
I noticed a todo tag, but didn't see any related restore resource cleanup, so I created this pull request. |
Contributor
|
thanks for your pr, but there's an issue with this implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DeleteRestoreCR *boolfield toRebuildInstancestruct