fix: use pax instead of tar for pkg payload extraction #1038
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
It is common to have
gnu-taralongside other GNU tools installed and aliased for compatibility reasons.However, this breaks the current make build. The following error happened when GNU tar tried to extract the pkg Payload (which is cpio+gzip, not tar) during
make all>installtarget, extracting pkg Payload tobin/andlibexec/:The build succeeded, the pkg was created, but the extraction silently failed, leaving
bin/containermissing.The proposed fix uses BSD-only binaries (no GNU equivalents that are commonly aliased), making the Makefile more portable.
Why
gunzip | cpioinstead oftar:gtar) cannotTesting