-
Notifications
You must be signed in to change notification settings - Fork 582
Add new system status command
#118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider changing this wording to
| print("apiserver is not running") | |
| print("apiserver is not registered with launchd") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion! It is definitely more precise than my wording.
Updated it to "apiserver is not running and not registered with launchd", as I think end users might not know what "registered with launchd" means.
|
Thanks for the change! :) |
adityaramani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just had a couple minor comments
Container services can be started and stopped using the `system start` and `system stop` commands. But there is no straightforward way for users to check if the services were already started. This commit adds a new `system status` command that shows wether the container services are running or not. The command only checks the status of the apiserver for now, but it could be expanded in the future to show more details.
Container services can be started and stopped using the
system startandsystem stopcommands. But there is no straightforward way for users to check if the services were already started.This PR adds a new
system statuscommand that shows wether the container services are running or not.The command only checks the status of the apiserver for now, but it could be expanded in the future to show more details.
Fixes #117.