Skip to content

Conversation

@pstoeckle
Copy link
Contributor

Hi there,

some small typos I fixed using typos.

Cheers,
Patrick

@egernst
Copy link
Contributor

egernst commented Jun 11, 2025

Hey @pstoeckle it seems like you'll need to run make fmt?

@pstoeckle
Copy link
Contributor Author

Hi @egernst,

I rebased my commit on the new main, and executed make fmt.

@dkovba
Copy link
Contributor

dkovba commented Jun 11, 2025

make fmt is using hawkeye for updating license headers.

@pstoeckle
Copy link
Contributor Author

pstoeckle commented Jun 11, 2025

The problem was not make fmt, but make proto.
Since the typo is in the proto buf which is cloned in the pipeline, newly generating the files from the protobuf creates the file with the typo, and, thus, hawkeye sees a diff and fails.

Now, the pipeline should be passing, and I fixed the typo in the protobuf file (see apple/container-builder-shim#15)

@katiewasnothere
Copy link
Contributor

katiewasnothere commented Jun 12, 2025

@pstoeckle Could you run make protos now that the container-builder-shim change has been merged? I made a PR here that updates the protos #176

@pstoeckle
Copy link
Contributor Author

Should I rebase again? 😅

@katiewasnothere
Copy link
Contributor

@pstoeckle Yes please! You may need to remove the second commit that updates the protos

@pstoeckle
Copy link
Contributor Author

Done!

@dkovba dkovba merged commit 84edaa2 into apple:main Jun 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants