Add container.cpus and container.memory system properties#1266
Merged
realrajaryan merged 3 commits intoapple:mainfrom Mar 4, 2026
Merged
Conversation
realrajaryan
force-pushed
the
users/realrajaryan/container-resource-properties
branch
from
1de01b3 to
99be8ed
Compare
jglogan
requested changes
Mar 2, 2026
| if let memory { | ||
| resource.memoryInBytes = try Parser.memoryString(memory).mib() | ||
| } else if let memStr = DefaultsStore.getOptional(key: .defaultContainerMemory) { | ||
| resource.memoryInBytes = try Parser.memoryString(memStr).mib() |
Contributor
There was a problem hiding this comment.
@realrajaryan could you rename memoryString to memoryStringAsMiB for this PR?
Understanding this line is currently difficult as there's know way to know what units are used for the return value.
realrajaryan
force-pushed
the
users/realrajaryan/container-resource-properties
branch
from
358875d to
a981a29
Compare
realrajaryan
force-pushed
the
users/realrajaryan/container-resource-properties
branch
from
a981a29 to
2dc824a
Compare
jglogan
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
This PR adds container.cpus and container.memory system properties as user-configurable defaults for container resource allocation when
--cpusor--memoryflags are not specified.Testing