[Build] Do not use unbounded DispatchIO readers for tar tranfers #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wlan0
commented
Jun 25, 2025
wlan0
commented
- Addresses [Bug]: Transferring context fails with out of space error #166
- Memory utilization explodes since there is no mechanism for backpressure
- Using a synchronous buffered reader seem to provide similar performance without the memory explosion issue
- 4MB buffer seems to provide the best results
| Metric | 1MB Buffer | 4MB Buffer | Unbounded Zero-Copy |
|---|---|---|---|
| Build Time | 149.33s | 138.57s | 139.79s |
| Max RAM Used | 2.16 GB | 3.02 GB | 3.52 GB |
| Peak Memory Footprint | 8.30 GB | 8.17 GB | 10.21 GB |
| Page Reclaims | 1,085,559 | 1,039,677 | 1,619,943 |
| Page Faults | 115 | 148 | 143 |
| CPU Usage (User+Sys) | 53.71s | 53.12s | 60.44s |
wlan0
force-pushed
the
streaming-tar
branch
2 times, most recently
from
179b018 to
a810641
Compare
3 tasks
3 tasks
katiewasnothere
approved these changes
Jun 25, 2025
- Addresses #166 - Memory utilization explodes since there is no mechanism for backpressure - Using a synchronous buffered reader seem to provide similar performance without the memory explosion issue - 4MB buffer seems to provide the best results | Metric | 1MB Buffer | 4MB Buffer | Unbounded Zero-Copy | |--------------------------|------------|------------|---------------------| | Build Time | 149.33s | 138.57s | 139.79s | | Max RAM Used | 2.16 GB | 3.02 GB | 3.52 GB | | Peak Memory Footprint | 8.30 GB | 8.17 GB | 10.21 GB | | Page Reclaims | 1,085,559 | 1,039,677 | 1,619,943 | | Page Faults | 115 | 148 | 143 | | CPU Usage (User+Sys) | 53.71s | 53.12s | 60.44s |
katiewasnothere
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.