Skip to content

Conversation

@jglogan
Copy link
Contributor

@jglogan jglogan commented Jun 30, 2025

* Closes apple#148.
* Storing the default nameserver in the bundle config
  means that DNS won't work if the container stops
  and then restarts later when the subnet address
  has changed.
Copy link
Contributor

@crosbymichael crosbymichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for our current implementation but adding this note for future us; assuming the gateway is the name server could cause a bug later on. We should probably look at making this more explicit within the network services to be more robust.

@jglogan
Copy link
Contributor Author

jglogan commented Jul 1, 2025

pol> assuming the gateway is the name server could cause a bug later on

Yep, this definitely assumes a vmnet network. For our future us, one possibility is that the attachment descriptor returned by the network helper could include a nameservers hint, if the network implementation can suggest one. We can always override the default policy by specifying nameservers explicitly when creating the container.

@jglogan jglogan merged commit 75e9285 into apple:main Jul 1, 2025
2 checks passed
@jglogan jglogan deleted the users/jglogan/dns-optional branch July 1, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network issue occurs when container build process installs pip packages

2 participants