Make image details public #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @Typ0genius thanks for the change! Could you add information to the PR description on the motivation behind this change? |
Contributor
Author
|
@katiewasnothere Sure, I have updated the description. |
katiewasnothere
approved these changes
Jul 17, 2025
|
Forgive if I'm wrong but I'm very much dropping into the project looking at recent commits to see if stuff I want has happened. Isn't this the CLI/tool and public programmatic APIs should be done via the swift framework? |
Contributor
|
@LiamKearn While this repo IS where you can build the daemon/CLI, the project is still importable/usable as a dependency if you wanted to interact with the daemon programmatically as it contains the client we use in the cli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to access the different variants of an image in my app, which information is only available in the ImageDetail. Although the function ClientImage.details() -> ImageDetail and its return type are already public, its properties aren’t, which prevents access to this information.