Skip to content

Applies feedback for PR #352. #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jglogan merged 1 commit into from
Jul 23, 2025
Merged

Applies feedback for PR #352. #365

jglogan merged 1 commit into from
Jul 23, 2025

Conversation

@jglogan
Copy link
Contributor

@jglogan jglogan commented Jul 23, 2025

  • Forgot to commit the changes to gracefully shut down the event loop group used by the port forwards.

@jglogan
Applies feedback for PR apple#352.
82b6ed2 
- Forgot to commit the changes to gracefully
  shut down the event loop group used by
  the port forwards.
@jglogan jglogan requested a review from katiewasnothere July 23, 2025 07:34
@jglogan jglogan merged commit f0eda65 into apple:main Jul 23, 2025
2 checks passed
@jglogan jglogan deleted the users/jglogan/shutdown-eventloopgroup branch July 24, 2025 00:04
@jglogan jglogan mentioned this pull request Jul 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katiewasnothere katiewasnothere katiewasnothere approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jglogan @katiewasnothere