Make "Plugin not found" message more descriptive #569
Conversation
|
This makes me think we should expose a |
|
Also, the license headers can be generated via |
| """ | ||
| Plugin 'container-\(command)' not found. | ||
| - If system services are not running, start them with: container system start | ||
| - If the plugin isn't installed, ensure it exists under: |
There was a problem hiding this comment.
@mazdak this all looks good. This one sentence is a bit confusing. What do you think about
- Check to see that the plugin exists under:
There was a problem hiding this comment.
What I see in my local build looks good.
Only other nit is that a blank line before Usage: might improve readability.
% bin/container foo
Warning! Running debug build. Performance may be degraded.
Error: Plugin 'container-foo' not found.
- If system services are not running, start them with: container system start
- If the plugin isn't installed, ensure it exists under:
- {my-project-path}/libexec/container-plugins/foo
- {my-project-path}/libexec/container/plugins/foo
Usage: container [--debug] <subcommand>
See 'container --help' for more information.There was a problem hiding this comment.
I have made both those changes.
mazdak
force-pushed
the
mazdak/fix-plugin-not-found-message
branch
from
4cac472 to
b2a0e2d
Compare
|
@mazdak Try rebasing and running |
Users frequently saw “failed to find plugin …” when the system services weren’t running; the message didn’t explain the root cause or where plugins are looked up. Added a test for the "Plugin not found" error
mazdak
force-pushed
the
mazdak/fix-plugin-not-found-message
branch
from
b2a0e2d to
09000a7
Compare
|
@mazdak Merged, thank you for the contribution! |
3 participants
Type of Change
Description
Users frequently saw “failed to find plugin …” when the system services weren’t running; the message didn’t explain the root cause or where plugins are looked up. No change to plugin execution flow; only error messaging and path discovery hints are improved for a better UX.
Motivation and Context
Users frequently saw “failed to find plugin …” when the system services weren’t running; the message didn’t explain the root cause or where plugins are looked up. I was confronted with this several times during plugin development because the container system was not running, but the error message led me to believe the files were missing.
Testing