Add force option to kernel set and add tests for kernel setting #579
+179
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
reviewed
Sep 5, 2025
dcantah
reviewed
Sep 5, 2025
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
LGTM, but one comment. Will re-review after!
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
kernel_set_tests
branch
from
e218218 to
70d0422
Compare
dcantah
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add option to force kernel setting and tests for CLI
kernel set. Related to #575.Motivation and Context
This PR adds additional tests to ensure that we can set kernels from local files, remote tar files, and local tar files. A new option
forceis added to thekernel setsubcommand which will overwrite an existing kernel with the same name if one exists to make testing easier. The tests ensure that a container can be started with the newly set kernel and resets to the default recommended kernel when complete.Testing