Use a lock consistently in the ExecutionContext class
#619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkovba
force-pushed
the
dkovba/execution-context
branch
from
c41b54f to
87d49ec
Compare
wlan0
reviewed
Sep 17, 2025
| /// - Throws: Any errors from the snapshotter | ||
| public func prepareSnapshot(for operationId: UUID) async throws -> Snapshot { | ||
| let parentCommitted = headSnapshot | ||
| let parentCommitted = lock.withLock { _headSnapshot } |
Contributor
There was a problem hiding this comment.
headSnapshot is already protected by a lock, is this necessary?
Contributor
Author
There was a problem hiding this comment.
The mixed use of headSnapshot and _headSnapshot might be confusing. But this is not incorrect.
wlan0
requested changes
Sep 17, 2025
Contributor
wlan0
left a comment
wlan0
left a comment
There was a problem hiding this comment.
one change seems redundant, but LGTM otherwise
wlan0
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR improve the consistency of using a lock in the
ExecutionContextclass.