Add and use container-runtime-linux start.
#654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
reviewed
Sep 22, 2025
Comment on lines
70
to
83
| let xpc = XPCServer( | ||
| identifier: machServiceLabel, | ||
| routes: [ | ||
| SandboxRoutes.bootstrap.rawValue: server.bootstrap, | ||
| SandboxRoutes.createProcess.rawValue: server.createProcess, | ||
| SandboxRoutes.state.rawValue: server.state, | ||
| SandboxRoutes.stop.rawValue: server.stop, | ||
| SandboxRoutes.kill.rawValue: server.kill, | ||
| SandboxRoutes.resize.rawValue: server.resize, | ||
| SandboxRoutes.wait.rawValue: server.wait, | ||
| SandboxRoutes.start.rawValue: server.startProcess, | ||
| SandboxRoutes.dial.rawValue: server.dial, | ||
| ], | ||
| log: log |
Contributor
There was a problem hiding this comment.
This is missing the new setup we have after the reworking.
Contributor
Author
There was a problem hiding this comment.
Rebased and relocated all the new setup from RuntimeLinuxHelper.swift to the start command.
- Part of apple#653. - No need for `defaultCommand` since ContainerService startup will write a new launchd plist with the `start` subcommand included.
jglogan
force-pushed
the
plugin-start
branch
from
21a641c to
4a30cb2
Compare
1 task
katiewasnothere
approved these changes
Sep 23, 2025
7 tasks
jglogan
added a commit
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startCLI subcommand for service plugins. #653.defaultCommandsince ContainerService startup will write a new launchd plist with thestartsubcommand included.Type of Change
Motivation and Context
Allows us to add commands to support post-installation, migration, etc.
Testing