Cleans up image subcommand options. #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Part of apple#515. - Order options alphabetically. - Use consistent descriptions for platform, os, arch. - Add os/arch options to push. - Rename ImageRemove to ImageDelete since delete is the primary command and rm is the alias.
jglogan
force-pushed
the
image-options
branch
from
4bf3083 to
68cb87b
Compare
dkovba
approved these changes
Sep 23, 2025
| name: .shortAndLong, | ||
| help: | ||
| "Amount of builder container memory (1MiByte granularity), with optional K, M, G, T, or P suffix" | ||
| help: "Amount of builder container memory (1MiByte granularity), with optional K, M, G, T, or P suffix" |
Contributor
There was a problem hiding this comment.
Should we remove the P suffix for simplicity?
| abstract: "Create a new reference for an existing image") | ||
|
|
||
| @Argument(help: "SOURCE_IMAGE[:TAG]") | ||
| @Argument(help: "the existing image reference (format: image-name[:tag])") |
Contributor
There was a problem hiding this comment.
Capitalize the help string.
| var source: String | ||
|
|
||
| @Argument(help: "TARGET_IMAGE[:TAG]") | ||
| @Argument(help: "the new image reference") |
Contributor
There was a problem hiding this comment.
Capitalize the help string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Clear, consistent presentation of command help.
Testing