Cleans up network and volume subcommands. #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Part of apple#515. - Order options alphabetically. - Use consistent delete logic for network and volume delete.
| group.addTask { | ||
| do { | ||
| // delete atomically disables the IP allocator, then deletes | ||
| // the allocator disable fails if any IPs are still in use |
Contributor
There was a problem hiding this comment.
Nit but can we do
Suggested change
| // the allocator disable fails if any IPs are still in use | |
| // the allocator. Disable fails if any IPs are still in use |
or split the sentence by different comment lines?
Contributor
Author
There was a problem hiding this comment.
Will do this fix in the registry PR which is yet to be approved.
katiewasnothere
approved these changes
Sep 22, 2025
Contributor
katiewasnothere
left a comment
katiewasnothere
left a comment
There was a problem hiding this comment.
Just the one suggestion, otherwise LGTM
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
See #515
Testing