ClientContainer: Remove response timeout from stop
#667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
changed the title
stop
After the large reworks, I'm not as worried about having this timeout anymore. Prior to the reworks stop was signaled via an async event sent to the daemon as stop was performed directly on the given runtime-helper instance. If anything errored during that it was common for things to explode, but now that stop is: client -> APIServer -> runtime-helper instance and the logic for stop has been improved quite a bit, in addition to stop no longer holding a lock during it's operation, I'm not sure we need this. In the future it'd also be nice to support no timeout (the timeout until we send SIGKILL, not response timeout) in which case we'd have to have an extra bit of logic here to skip the response timeout in that case anyways.
dcantah
force-pushed
the
rm-stop-timeout
branch
from
b997d39 to
2c233a6
Compare
jglogan
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the large reworks, I'm not as worried about having this timeout anymore. Prior to the reworks stop was signaled via an async event sent to the daemon as stop was performed directly on the given runtime-helper instance. If anything errored during that it was common for things to explode, but now that stop is:
client -> APIServer -> runtime-helper instance
and the logic for stop has been improved quite a bit, in addition to stop no longer holding a lock during it's operation, I'm not sure we need this. In the future it'd also be nice to support no timeout (the timeout until we send SIGKILL, not response timeout) in which case we'd have to have an extra bit of logic here to skip the response timeout in that scenario anyways.