Skip to content

Conversation

@noritaka1166
Copy link
Contributor

fix typos

Copy link

@sellers sellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all of these changes are cosmetic and will not interruption or change functionality. Good spelunking.

@egernst
Copy link
Contributor

egernst commented Jun 11, 2025

CI is suggesting a run of make fmt?

@noritaka1166
Copy link
Contributor Author

CI is suggesting a run of make fmt?

@egernst
I tried running “make fmt”, but it didn't show any differences.

@noritaka1166
Copy link
Contributor Author

CI is suggesting a run of make fmt?

@egernst I tried running “make fmt”, but it didn't show any differences.

@egernst
I looked again at Sources/ContainerBuild/Builder.grpc.swift and it says “DO NOT EDIT.”
Therefore, I reverted it.

@noritaka1166
Copy link
Contributor Author

Sources/ContainerBuild/Builder.grpc.swift

Looks like a typo from https://github.com/apple/container-builder-shim/blob/main/pkg/api/Builder.proto.
I will fix it in another PR.

@noritaka1166 noritaka1166 force-pushed the fix-typos branch 3 times, most recently from e7b7eb1 to 3871779 Compare June 12, 2025 00:46
@katiewasnothere katiewasnothere merged commit 098021f into apple:main Jun 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants