Skip to content

Conversation

@saehejkang
Copy link
Contributor

@saehejkang saehejkang commented Oct 21, 2025

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Closes #665

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@saehejkang saehejkang changed the title [network-createion]: Add createdAt field [network-creation]: Add createdAt field Oct 21, 2025
@saehejkang
Copy link
Contributor Author

Not sure if I added the createdAt field correctly to the decoder, but I am getting an error when testing any network commands.

Error: keyNotFound(CodingKeys(stringValue: "createdAt", intValue: nil), Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "running", intValue: nil), RunningCodingKeys(stringValue: "_0", intValue: nil)], debugDescription: "No value associated with key CodingKeys(stringValue: \"createdAt\", intValue: nil) (\"createdAt\").", underlyingError: nil))

Maybe something to do with the encoding and decoding done in the create function here? First time looking into the api/client side of things.

@saehejkang
Copy link
Contributor Author

Not sure the protocol with pinging maintainers, as I don't want to bloat anyone's notifications.

But @jglogan , I would love to get some 👀 on this. Mainly to check if I am even taking the right steps in what we want accomplish here.

@jglogan
Copy link
Contributor

jglogan commented Oct 25, 2025

@saehejkang I'll have a look next week.

@jglogan jglogan self-requested a review October 25, 2025 14:04
@jglogan
Copy link
Contributor

jglogan commented Oct 30, 2025

@saehejkang I'll have a review of this done by the end of the day. The main thing I want to consider is whether what you have here follows a pattern that we can apply to the metadata for all our managed resources.

@saehejkang saehejkang force-pushed the add-new-network-metadata branch from 9fd5f2d to 638912c Compare November 1, 2025 07:03
Copy link
Contributor

@jglogan jglogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saehejkang could you make the property name change and the deserialization change, and then we can merge this and use it as the pattern for the other PR.

@saehejkang saehejkang force-pushed the add-new-network-metadata branch from efed155 to 19f4e75 Compare December 2, 2025 05:41
@saehejkang saehejkang changed the title [network-creation]: Add createdAt field [networks]: Add creationDate field Dec 2, 2025
@saehejkang saehejkang marked this pull request as ready for review December 2, 2025 05:43
@jglogan jglogan merged commit 6f55360 into apple:main Dec 2, 2025
2 checks passed
@saehejkang saehejkang deleted the add-new-network-metadata branch December 6, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Add Creation Date in Network Metadata

2 participants