Propagate host ssh socket permissions to relay socket in guest. #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| if let socketUrl = Self.hostSocketUrl(config: config) { | ||
| if let socketUrl = Self.sshAuthSocketHostUrl(config: config) { | ||
| let socketPath = socketUrl.path(percentEncoded: false) | ||
| let attrs = try FileManager.default.attributesOfItem(atPath: socketPath) |
Contributor
There was a problem hiding this comment.
do we wanna handle the scenario when attributesOfItem throws?
Contributor
Author
There was a problem hiding this comment.
ah yeah, let's default to what we were doing before for that case as well
realrajaryan
approved these changes
Oct 27, 2025
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Oct 28, 2025
…e#811) - Closes apple#580. - Depends on apple/containerization#362. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation update ## Testing - [x] Tested locally - [ ] Added/updated tests - [ ] Added/updated docs
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--sshflag doesn't work with non-root user #580.Type of Change
Testing