Fix progress bar crash on cached image rebuilds #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglogan
reviewed
Nov 17, 2025
| } | ||
| return img | ||
| // Use fetch() which checks cache first, then pulls if needed | ||
| return try await ClientImage.fetch(reference: ref, platform: platform, progressUpdate: progress.handler) |
Contributor
There was a problem hiding this comment.
fetch() only retrieves the manifest if needed, doesn't it?
I don't see how this actually pulls content. The code before the original progress bar changed looked like:
guard let img = try? await ClientImage.pull(reference: ref, platform: platform) else {
return try await ClientImage.fetch(reference: ref, platform: platform)
Contributor
Author
There was a problem hiding this comment.
The original code was backwards. fetch() tries to get the image from the local cache first, and if not found, it calls pull().
jglogan
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
BuildImageResolverto usefetch()instead ofpull().fetch()checks the cache first and only pulls if needed, preventing incorrect progress events (e.g., "1/1 KB" metadata checks) on cached images that caused the progress bar width calculation to produce negative/weird padding counts, triggering "Fatal error: Negative count not allowed" crashes during rebuilds.